Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different workshare calculations for rewarded vs active set #951

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

durch
Copy link
Contributor

@durch durch commented Dec 8, 2021

Closes #2071 and #2070

Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually looks good to me. However, I've got one question - how does this calculation update affect delegators rewarding? Should they also be adjusted?

@durch
Copy link
Contributor Author

durch commented Dec 9, 2021

Conceptually looks good to me. However, I've got one question - how does this calculation update affect delegators rewarding? Should they also be adjusted?

Overall the node reward will be lower, so everyone will get less, owner, and delegators

@jstuczyn
Copy link
Contributor

jstuczyn commented Dec 9, 2021

Conceptually looks good to me. However, I've got one question - how does this calculation update affect delegators rewarding? Should they also be adjusted?

Overall the node reward will be lower, so everyone will get less, owner, and delegators

I might be misremembering, but wasn't it the case that delegators of nodes from the inactive set aren't getting anything?

@durch
Copy link
Contributor Author

durch commented Dec 9, 2021

Conceptually looks good to me. However, I've got one question - how does this calculation update affect delegators rewarding? Should they also be adjusted?

Overall the node reward will be lower, so everyone will get less, owner, and delegators

I might be misremembering, but wasn't it the case that delegators of nodes from the inactive set aren't getting anything?

I'm not sure, will tap Claudia

@durch
Copy link
Contributor Author

durch commented Dec 9, 2021

Conceptually looks good to me. However, I've got one question - how does this calculation update affect delegators rewarding? Should they also be adjusted?

Overall the node reward will be lower, so everyone will get less, owner, and delegators

I might be misremembering, but wasn't it the case that delegators of nodes from the inactive set aren't getting anything?

I'm not sure, will tap Claudia

Good thing I did, it slipped my mind completely that this has changed, and we did not capture the change with the ticket. Double checked with Claudia, and we should be good

@jstuczyn
Copy link
Contributor

One more thing I forgot to mention - we probably also need to update validator API and how it calculates all those values as currently it only sends rewards to the CURRENT rewarded set

@durch
Copy link
Contributor Author

durch commented Dec 13, 2021

One more thing I forgot to mention - we probably also need to update validator API and how it calculates all those values as currently it only sends rewards to the CURRENT rewarded set

I know what you mean, we need to ticket that up, but we also need to discuss how we'll go about actually updating the rewarded set at required intervals

@durch durch merged commit 791d051 into develop Dec 13, 2021
@durch durch deleted the feature/reward-set-rewarding branch December 13, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate rewarded set into tokenomics rewarding
3 participants