Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validator api shutdown #1573

Merged
merged 12 commits into from
Aug 30, 2022
Merged

Feature/validator api shutdown #1573

merged 12 commits into from
Aug 30, 2022

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Aug 30, 2022

Description

To improve the validator api shutdown:

  • only senders get the shutdown signal, and receivers shutdown when the channel closes instead of panicking
  • shutdown signal gets precedence in concurrency of select!
  • cpu intensive, thread blocking crypto task of preparing packets is put on separate thread, to benefit from the time slicing of the tokio runtime and not block shutdown signal from being received

Closes: #1437

Checklist:

  • added a changelog entry to CHANGELOG.md

@neacsu neacsu merged commit a6aba3d into develop Aug 30, 2022
@neacsu neacsu deleted the feature/validator_api_shutdown branch August 30, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SIGTERM handler to nym-validator-api
1 participant