Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] fixing cdnvm on .bashrc (auto nvm use) #1971

Merged
merged 1 commit into from
Dec 31, 2018
Merged

[Docs] fixing cdnvm on .bashrc (auto nvm use) #1971

merged 1 commit into from
Dec 31, 2018

Conversation

jabiinfante
Copy link
Contributor

@jabiinfante jabiinfante commented Dec 31, 2018 •
edited by ljharb
Loading

Automatically call nvm use using .bashrc file is broken for directories with to-be-escaped chars.
$ cd the\ folder/
bash : cd : too many arguments

Quoting $@ will fix this issue.

ljharb
ljharb approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 5e065ec into nvm-sh:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational shell: bash/sh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabiinfante @ljharb