Improve bash_completion coding style #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
May 22, 2018
| @@ -3,19 +3,19 @@ | |||
| # bash completion for Node Version Manager (NVM) | |||
|
|
|||
| if ! command -v nvm &> /dev/null; then | |||
| return | |||
There was a problem hiding this comment.
is editorconfig not being enforced on this file already?
There was a problem hiding this comment.
Nope as it can't understand the syntax, it can yell when the indentation is 3 or 5 spaces, but as we set to 2 space, 4 or 6 spaces will be both fine to it.
There was a problem hiding this comment.
Why can't it understand the syntax?
There was a problem hiding this comment.
it's not language based.
bash_completion
Outdated
| @@ -3,19 +3,19 @@ | |||
| # bash completion for Node Version Manager (NVM) | |||
|
|
|||
| if ! command -v nvm &> /dev/null; then | |||
| return | |||
| return | |||
| fi | |||
|
|
|||
| __nvm_generate_completion() | |||
| { | |||
There was a problem hiding this comment.
these curly braces should all be in OTBS, not in allman style.
bash_completion
Outdated
| esac | ||
| case "${current_word}" in | ||
| -*) __nvm_options ;; | ||
| *) __nvm_generate_completion "${COMMANDS}" ;; |
There was a problem hiding this comment.
these really only need one space after )
There was a problem hiding this comment.
Cool, I prefer that.
PeterDaveHello
force-pushed
the
bash_completion
branch
2 times, most recently
from
9690c2d
to
e7ade17
Compare
|
Updated. BTW, CI not triggered? |
ljharb
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the indent and make the code more readable