Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove ftdetect file as Neorg is now natively recognized by Neovim #1083

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

NTBBloodbath
Copy link
Member

This PR aims to remove vim.filetype logic in setup as it is already covered by the ftdetect file.

FYI: ftdetect directory is going to be deleted once Neovim v0.10 release is stable as I've added support for norg filetype in Neovim's core.

@max397574
Copy link
Contributor

this can just be merged after 0.10 release right?

@NTBBloodbath
Copy link
Member Author

this can just be merged after 0.10 release right?

Yeah, we've decided to merge this once 0.10 is released. We will also nuke ftdetect along with this PR then

@max397574
Copy link
Contributor

well then you could also nuke it in this pr then ig

@max397574
Copy link
Contributor

Not sure how plenary filetype detection works but ig we could also remove this then:
#1157

@max397574
Copy link
Contributor

@vhyrro

@NTBBloodbath NTBBloodbath changed the title cleanup(neorg.lua): remove vim.filetype logic in setup cleanup: remove ftdetect file as Neorg is now natively recognized by Neovim May 26, 2024
@NTBBloodbath
Copy link
Member Author

Updated title and rebased to update according to the latest codebase changes

@vhyrro vhyrro merged commit 5c32056 into nvim-neorg:main Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants