Rule for branch dash 0

[ProfessorTom]

fixes fat-fingering git branch -0 instead of git branch -v

[nvbn]

Nice idea, maybe it will be a good thing to make that more generic? To just replace any argument that starts with 0 if it appears in stderr.

[ProfessorTom]

@nvbn When I quickly read your comment on my phone, I thought making this fix more generic sounded like a good idea, but upon reflection, I'm not so sure.

In the specific case I coded up, the argument needs to turn into a flag. Would making that assumption more generic (i.e. convert all arguments starting with 0 to -) make sense?

For that matter, what would the "undo" action look like, or would there even need to be an "undo" action? (In the specific example here, I need to delete a branch that was just accidentally created...what should the proper response be if git branch 0v wasn't the command?

[nvbn]

@ProfessorTom you're right, initially I thought that git branch 0v prints something, but it just creates a branch.

I guess the only way to generalize this rule is to also support cases like git branch 0l, git branch 0a and etc, so just check that the argument after branch starts with 0.

[ProfessorTom]

Do you still want me to generalize this feature turning the 0 into a - and deleting the branch just created in all cases?

Is there a case where this would cause more harm than good?

[ProfessorTom]

bumping to get a review and hopefully a merge.

[scorphus]

Hey, thanks for contributing! Please mind my change requests including the correct naming of the test file test_get_branch_0v_to_dash_v.py into test_git_branch_0v_to_dash_v.py.

[ProfessorTom]

@scorphus @nvbn Can I get a review on my latest changes?

[ProfessorTom]

What will it take to get this new approach reviewed and merged? cc @nvbn @scorphus @jamtur01

[scorphus]

Thank you for contributing, @ProfessorTom 👍

Please check a new PR, which is probably going to be #1212.

[ProfessorTom]

Thank you for merging.