This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): don't try to override computed layouts in definePageMeta
#9161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have a question too: as the document says we can use ref for the reactive layout but it throws an error (compiler macros I think) when using just a simple ref (without computed wrapper). Do you have any idea about that? |
danielroe
reviewed
Nov 18, 2022
danielroe
reviewed
Jan 14, 2023
danielroe
reviewed
Jan 14, 2023
danielroe
approved these changes
Jan 14, 2023
danielroe
changed the title
definePageMeta's layout propertydefinePageMeta
danielroe
changed the title
definePageMetadefinePageMeta
Merged
danielroe
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#15344
❓ Type of change
📚 Description
Hey
As mentioned in the linked issues, there is a bug with the computed layout when using
definePageMeta.Also, there is a workaround for that as @danielroe mentioned it.
But after a bit of research I figured out what's going on and it can be fixed with this PR.
I also changed the example to be clearer.
📝 Checklist