Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): update class prop type for head components #9133

Merged
merged 4 commits into from
Jan 14, 2023
Merged

fix(nuxt): update class prop type for head components #9133

merged 4 commits into from
Jan 14, 2023

Conversation

okakyo
Copy link
Contributor

@okakyo okakyo commented Nov 17, 2022 •
edited

🔗 Linked issue

nuxt/nuxt#15514

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

resolve nuxt/nuxt#15514 - Add an Object to html and body class prop to solve a type error.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 17, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@okakyo okakyo marked this pull request as draft November 17, 2022 17:58
@okakyo okakyo marked this pull request as ready for review November 17, 2022 18:00
@okakyo okakyo changed the title fix html and body class prop fix(nuxt): html and body class prop Nov 17, 2022
@okakyo okakyo changed the title fix(nuxt): html and body class prop fix(nuxt): Add an Objectconstructor to html and body class prop Nov 17, 2022
@okakyo okakyo changed the title fix(nuxt): Add an Objectconstructor to html and body class prop fix(nuxt): Update html and body class prop type Nov 17, 2022
@okakyo okakyo changed the title fix(nuxt): Update html and body class prop type fix(nuxt): update html and body class prop type Nov 17, 2022
danielroe
danielroe approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielroe danielroe changed the title fix(nuxt): update html and body class prop type fix(nuxt): update class prop type for head components Jan 14, 2023
@danielroe danielroe merged commit 86ed4ef into nuxt:main Jan 14, 2023
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Merged
danielroe pushed a commit that referenced this pull request Jan 21, 2023
@okakyo @danielroe
fix(nuxt): update class prop type for head components (#9133)
e292763
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Html and Body components: class prop type error if not string
2 participants
@okakyo @danielroe