-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxt, schema): official @vueuse/head v1 support #8975
Conversation
|
❌ Deploy Preview for nuxt3-docs failed.
|
test/bundle.test.ts
Outdated
@@ -33,6 +33,7 @@ describe.skipIf(isWindows)('minimal nuxt application', () => { | |||
"_nuxt/error-404.js", | |||
"_nuxt/error-500.js", | |||
"_nuxt/error-component.js", | |||
"_nuxt/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why this is being generated
Ready for review, I'll write a couple of tests soon |
Thanks so much for working on this @harlan-zw 💯 I will have a local look soon but overall unhead migration seems already in good direction. Since we are so close to latest RC and v3 release, i think it is good idea to consider including this change and release fixes in upstream if any. Only, i would appreciate if we can minimize new feature additions to reduce chances of breaking changes for end-users. |
Good idea, will remove anything non-essential. I can release a module to opt-in to these new features |
Overall looks good to me! Let's try changes on Nuxt edge. |
… into feat/vueuse-head-v1
It doesn't seem that useHead updates on computed properties. Example:
Even if |
I think you have to use just the computed ref. So use |
Ah, of course. Thank you. |
🔗 Linked issue
Remake of PR #8908 (comment)
<script>
in rendered HTML whenssr: false
nuxt#14172❓ Type of change
📚 Description
New Nuxt v3 projects are already using v1 @vueuse/head outside of this PR. There are no open issues for the v1 release currently.
This PR aims to:
<script>
in rendered HTML whenssr: false
nuxt#14172📝 Checklist
Basic documentation, will need continued work over the coming weeks. I've kept the two new composable undocumented for the initial release, shouldn't be an issue for now?