Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(schema)!: use strict typescript mode by default #8667

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 3, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#15327

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This enables TypeScript's strict mode by default for users who are using TS. This is a better default and best practice.

πŸ‘‰ Migration

Users can disable this if they prefer.

export default defineNuxtConfig({
  typescript: {
    strict: false
  }
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added types 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Nov 3, 2022
@danielroe danielroe requested a review from pi0 November 3, 2022 19:13
@danielroe danielroe self-assigned this Nov 3, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 3, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 3, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 6374e66
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636412c3c05bb600097ee618

@pi0 pi0 merged commit f3fbef9 into main Nov 3, 2022
@pi0 pi0 deleted the fix/strict-ts branch November 3, 2022 19:19
@pi0
Copy link
Member

pi0 commented Nov 3, 2022

(merged too early types need to be updated!)

@danielroe
Copy link
Member Author

pr already open :-)

This was referenced Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TypeScript strict mode by default
2 participants