Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(test-utils): override NITRO_PORT as well #8458

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix(test-utils): override NITRO_PORT as well #8458

merged 1 commit into from
Oct 25, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15183

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We override PORT but also need to override NITRO_PORT if this is set by the user in an .env file.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels Oct 25, 2022
@danielroe danielroe requested a review from pi0 October 25, 2022 09:15
@danielroe danielroe self-assigned this Oct 25, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 25, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 25, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit eacf73b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6357a91a8c5b010008783635

@pi0 pi0 merged commit 452766e into main Oct 25, 2022
@pi0 pi0 deleted the fix/test-port branch October 25, 2022 09:17
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NITRO_PORT cause setup() failed in test
2 participants