This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor(schema)!: disable app.pageTransition
and app.layoutTransition
by default
#8436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you @danielroe We need to update the documentation as well (https://v3.nuxtjs.org/getting-started/transitions) to explain how to enable page transition and layouts transitions. |
Thank you - good catch! π |
app.pageTransition
and app. layoutTransition
by default
app.pageTransition
and app. layoutTransition
by defaultapp.pageTransition
and app. layoutTransition
by default
pi0
approved these changes
Oct 24, 2022
app.pageTransition
and app. layoutTransition
by defaultapp.pageTransition
and app.layoutTransition
by default
Fixing test failure. On plane, so may take a minute. |
atinux
approved these changes
Oct 24, 2022
antfu
approved these changes
Oct 24, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#8434 (comment)
β Type of change
π Description
This disables page/layout transitions by default. They cause issues like nuxt/nuxt#13471 and nuxt/nuxt#15239 when many users may not be using them at all ...
Β π Migration
If you were using page/layout transitions, you can add the following to your nuxt config to re-enable the previous behaviour:
π Checklist