Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(schema, nuxt): allow user-configurable serverDir #7868

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14944

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allows user to specify serverDir.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 27, 2022
@danielroe danielroe requested a review from pi0 September 27, 2022 14:10
@danielroe danielroe self-assigned this Sep 27, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 27, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 27, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3521650
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6333045ebf54200008448d9b

@cpreston321
Copy link
Contributor

cpreston321 commented Sep 27, 2022

@danielroe Do we want to update docs with the new config option apart of this PR ? https://v3.nuxtjs.org/api/configuration/nuxt.config

@danielroe
Copy link
Member Author

@cpreston321 You are certainly right, but that page is auto generated from the schema, so it should be up-to-date, unless there are other pages or sections that also need to be updated.

@cpreston321
Copy link
Contributor

@danielroe you are right! I honestly thought it was manual and not dynamic!

@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe requested a review from atinux October 10, 2022 10:13
@danielroe danielroe changed the title feat(schema, nuxt): allow user-configurable serverDir feat(schema, nuxt): allow user-configurable serverDir Oct 10, 2022
@danielroe danielroe merged commit 81a8a25 into main Oct 10, 2022
@danielroe danielroe deleted the feat/server-dir branch October 10, 2022 10:49
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An option for having separate server and client directories
3 participants