Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(head): allow using the default slot for script content like noscript #7858

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

MiniDigger
Copy link
Contributor

@MiniDigger MiniDigger commented Sep 27, 2022

πŸ”— Linked issue

Resolves nuxt/nuxt#15033

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves nuxt/nuxt#15033 by aligning the script component's functionality to the noscript and style tags, which already allow using the default slot to specify the children property of useHead.

(not sure if this should be marked as a new feature or an enhancement)
(I also did not find any documentation that I should update, the documentation is written in a way where I already thought this is possible :P)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Sep 27, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 27, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit f7e45c9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6332c4d3c6534800092c4eba

@danielroe danielroe changed the title feat(head): allow using the default slot for script content (closes feat(head): allow using the default slot for script content Sep 27, 2022
@atinux atinux changed the title feat(head): allow using the default slot for script content fix(head): allow using the default slot for script content like noscript Oct 3, 2022
@atinux atinux merged commit 63c8805 into nuxt:main Oct 3, 2022
@MiniDigger MiniDigger deleted the feat/7853 branch October 3, 2022 14:48
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using textContent of <Script> head component
3 participants