Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(test-utils): support vitest v0.20.x #7712

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix(test-utils): support vitest v0.20.x #7712

merged 1 commit into from
Sep 21, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13394, resolves nuxt/nuxt#14975

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Vitest v0.20 added an additional parameter, which we weren't respecting with test-utils. This PR also adds nuxt/test-utils to deps.inline which is required to avoid Vitest was initialized with native Node instead of Vite Node error.

We can drop the workaround if we want to have a hard dependency on vitest 0.20+

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working cli πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels Sep 21, 2022
@danielroe danielroe requested review from pi0 and antfu September 21, 2022 09:15
@danielroe danielroe self-assigned this Sep 21, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 21, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit cad8f5a
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632ad6367f2e78000815041b

@pi0 pi0 changed the title fix(test-utils): handle vitest v0.20 fix(test-utils): support vitest v0.20.x Sep 21, 2022
@pi0 pi0 merged commit 0640a6c into main Sep 21, 2022
@pi0 pi0 deleted the fix/test-utils-cli branch September 21, 2022 10:20
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working cli πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils
Projects
None yet
2 participants