Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): only observe tag elements for <NuxtLink> prefetching #7679

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14899

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's possible that NuxtLink doesn't render an HTML element; we can skip observing it in this case and leave the user to implement prefetching on their own.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 20, 2022
@danielroe danielroe requested a review from pi0 September 20, 2022 09:25
@danielroe danielroe self-assigned this Sep 20, 2022
@netlify
Copy link

netlify bot commented Sep 20, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 98dd11b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63298721b26d4c0008f126dd

@pi0 pi0 changed the title fix(nuxt): only observe elements, not comments or text nodes fix(nuxt): only observe tag elements for <NuxtLink> prefetching Sep 20, 2022
@pi0 pi0 merged commit 98ce2e6 into main Sep 20, 2022
@pi0 pi0 deleted the fix/custom-observe branch September 20, 2022 09:29
@pi0 pi0 mentioned this pull request Sep 20, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt-Link issue in rc-10
2 participants