Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): normalize vite-node error data #7589

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix(vite): normalize vite-node error data #7589

merged 2 commits into from
Sep 16, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 16, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#14909

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There are vast different possibilities from errors rollup and vite throw. Since vite-node tries to make a network request to fetch the modules, we were missing some information (such as module id). This PR tries to normalize it beforehand.

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 16, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3f5781d
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6324b29ea701ce000833bf96

@pi0 pi0 marked this pull request as ready for review September 16, 2022 17:41
@pi0 pi0 merged commit cfaca9c into main Sep 16, 2022
@pi0 pi0 deleted the fix/vite-node-error branch September 16, 2022 17:43
@pi0 pi0 mentioned this pull request Sep 20, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vite-node] [ERR_MODULE_NOT_FOUND]
2 participants