Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): do not pass prefetched class to custom link #7522

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14897

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We shouldn't pass prefetched class to routerlink if it's a custom link. (Later, might be worth thinking about how to pass prefetched class to slot.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 14, 2022
@danielroe danielroe requested a review from pi0 September 14, 2022 21:08
@danielroe danielroe self-assigned this Sep 14, 2022
@netlify
Copy link

netlify bot commented Sep 14, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 9ae04d1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6322d98efaeb8d0008b8eadc
😎 Deploy Preview https://deploy-preview-7522--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtLink with custom attribute causes vue warning in RC10
2 participants