This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(nuxt): pass fully resolved path to nitro dist files #7494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
247e18b
to
c98e5c7
Compare
danielroe
commented
Sep 15, 2022
danielroe
commented
Sep 15, 2022
danielroe
commented
Sep 15, 2022
I would like to iterate on this (moving some of this to |
pi0
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM (i had been pending it for rc.11 to try on edge)
pi0
reviewed
Sep 15, 2022
@@ -70,7 +70,8 @@ export async function initNitro (nuxt: Nuxt) { | |||
nuxt.options.buildDir | |||
]), | |||
'nuxt/dist', | |||
'nuxt3/dist' | |||
'nuxt3/dist', | |||
distDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to exclude dist dir for prerender (will come with another PR if needed)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
bug
Something isn't working
π¨ p3-minor-bug
Priority 3: a bug in an edge case that only affects very specific usage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#14753
β Type of change
π Description
This PR improves the testing for inlining nuxt assets in the build:
nuxt/app
.π Checklist