Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

perf(nuxt): only inject preload helper when webpack is used #7460

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This started out as a simple small perf improvement but ended up fixing a couple of bugs as well. The changes are:

  • only inject the server preload plugin when webpack builder is used (it adds a needless overhead with vite)
  • update NuxtOptions schema so it correctly shows resolved value of builder
  • update resolver for builder so it respects a custom builder value

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing performance labels Sep 12, 2022
@danielroe danielroe requested a review from pi0 September 12, 2022 22:12
@danielroe danielroe self-assigned this Sep 12, 2022
@netlify
Copy link

netlify bot commented Sep 12, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 50cc1e1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/631fafb869f4df000985e246

@pi0 pi0 merged commit 31de181 into main Sep 13, 2022
@pi0 pi0 deleted the perf/preload-tidy branch September 13, 2022 10:57
This was referenced Sep 14, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants