Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): use same asset filenames between server and client #7436

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14878

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It seems we need to share asset filename generator between server + client so filenames match up between client + server builds.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 12, 2022
@danielroe danielroe requested a review from pi0 September 12, 2022 09:52
@danielroe danielroe self-assigned this Sep 12, 2022
@netlify
Copy link

netlify bot commented Sep 12, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit d8cd66e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/631f0164cd0737000925f86c

@pi0 pi0 changed the title fix(vite): share asset filenames between server + client fix(vite): use same asset filenames between server and client Sep 12, 2022
@pi0 pi0 merged commit d507816 into main Sep 12, 2022
@pi0 pi0 deleted the fix/vite-server-assets branch September 12, 2022 10:12
This was referenced Sep 14, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3 rc 9 renders all @ symbol in assets url in ssr incorrectly and results in 404
2 participants