Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): fix lazy import of .client components #7422

Merged
merged 7 commits into from
Oct 3, 2022

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

resolve nuxt/nuxt#14868

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹ , this PR change the component loader to wrap the lazy loaded component instead of wrapping the async component. Wrapping the async component with createClientOnly prevent the component from being mounted.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 11, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit ef3833d
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6329d4e3a2ed210009086705

@huang-julien huang-julien marked this pull request as draft September 11, 2022 21:20
@huang-julien huang-julien marked this pull request as ready for review September 11, 2022 21:32
@pi0 pi0 requested review from antfu and danielroe September 12, 2022 08:33
@pi0 pi0 force-pushed the main branch 2 times, most recently from 247e18b to c98e5c7 Compare September 14, 2022 10:41
@atinux atinux merged commit 2c8c212 into nuxt:main Oct 3, 2022
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy .client components are not mounted or cause hydration issues
3 participants