Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(webpack): don't parse styles for composable keys #7333

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14834

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

With webpack, we have some code in a string in the style block, e.g.:

const code = ["\\nconst a ..."]

This wrongly gets parsed by the composable keys, and \\n breaks the parser.

But we shouldn't be parsing code from a style block for automatic useFetch/useState keys, anyway.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working webpack ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 7, 2022
@danielroe danielroe requested a review from pi0 September 7, 2022 20:45
@danielroe danielroe self-assigned this Sep 7, 2022
@netlify
Copy link

netlify bot commented Sep 7, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3a71f1d
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/631902e4c0bad100078f4684

@pi0 pi0 merged commit be77d47 into main Sep 8, 2022
@pi0 pi0 deleted the fix/style-parsing branch September 8, 2022 08:55
This was referenced Sep 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf webpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builder webpack: [unhandledRejection] Expecting Unicode escape sequence \uXXXX
2 participants