Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't override payload error if it is present #7290

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14695

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently if a renderering error occurs after another error the rendering error will take precedence. (e.g. if an error is thrown in <script setup>). This PR simply ensures that the original error is the one we handle.

I've moved the test case to the end of the file as vuejs/core#6110 means that the dev test fixture is broken after a rendering error. We either need to work around it in a separate PR or 🀞 that it is resolved upstream. (But either way, the issue already exists apart from this PR.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 6, 2022
@danielroe danielroe requested a review from pi0 September 6, 2022 14:50
@danielroe danielroe self-assigned this Sep 6, 2022
@netlify
Copy link

netlify bot commented Sep 6, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit c809681
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63175e54442062000881475b

@pi0 pi0 merged commit 1ca294e into main Sep 6, 2022
@pi0 pi0 deleted the fix/no-override-error branch September 6, 2022 16:21
@danielroe
Copy link
Member Author

The upstream bug has been fixed in Vue 3.2.29, for anyone tracking it. πŸ₯³

confirmed in #7321.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 (from template) rendered instead of 404 (from createErrror)
2 participants