This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(webpack): promisify webpack dev/hot handlers using h3.promisifyHandler
#7275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
|
I think we can now remove |
pi0
changed the title
h3.promisifyHandler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14809
❓ Type of change
📚 Description
Currently the first
next()call from webpack devMiddleware short-circuits second next call from hotMiddleware meaning we currently get a 404 for webpack HMR endpoint.I think it's a non-breaking change to update schema type for devMiddleware (as CompatibilityEvent should be backwards compatible).
📝 Checklist