Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(head): case http-equiv correctly #7190

Merged
merged 1 commit into from
Sep 3, 2022
Merged

fix(head): case http-equiv correctly #7190

merged 1 commit into from
Sep 3, 2022

Conversation

harlan-zw
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, when using the Meta component, it's not possible to provide a value for http-equiv. This is because http-equiv gets turned to httpEquiv, from Vue prop passing.

httpequiv is the final DOM result and it's not honoured by browsers

This PR simply swaps out the key for the correct one, I beleive this will be a temporary fix if unjs is working on a dom handling package.

Reproduction

https://stackblitz.com/edit/nuxt-starter-jdegdy?file=app.vue

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 3, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 29fdc5f
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6313471be8d0910008fa2432
😎 Deploy Preview https://deploy-preview-7190--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❀️

@pi0 pi0 merged commit fe3fc34 into nuxt:main Sep 3, 2022
@pi0
Copy link
Member

pi0 commented Sep 3, 2022

Thanks!

This was referenced Sep 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants