This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxt): add default slot to <NuxtLoadingIndicator>
#7128
Merged
danielroe
merged 6 commits into
nuxt:main
from
daniil4udo:feature/nuxt-loading-indicator-slot
Oct 10, 2022
Merged
feat(nuxt): add default slot to <NuxtLoadingIndicator>
#7128
danielroe
merged 6 commits into
nuxt:main
from
daniil4udo:feature/nuxt-loading-indicator-slot
Oct 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
manniL
reviewed
Sep 1, 2022
ae4f41a
to
4660e04
Compare
038332c
to
be160f2
Compare
manniL
approved these changes
Sep 14, 2022
be160f2
to
f43233e
Compare
247e18b
to
c98e5c7
Compare
3550c40
to
3eb8a58
Compare
daniil4udo
commented
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alexander Lichter <github@lichter.io>
3eb8a58
to
d3b9226
Compare
danielroe
approved these changes
Oct 9, 2022
<NuxtLoadingIndicator>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
enhancement
New feature or request
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
Add slot to the NuxtLoadingIndicator in case user want to add additional element (like spinner)
π Description
π Checklist