This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor(nuxt)!: rename autoImports
to imports
#6864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
7 tasks
I really love renaming of this PR and I think it worth it doing for both nuxt and nitro ( @antfu do you mind to open a PR for it) Only issue is with deprecation of hooks it doesn't works because we set deprecated hooks in auto imports module and it happens after other modules and hooks by user config are registered. It could be a big breaking change I like to avoid. |
7 tasks
Nitro PR: unjs/nitro#433 Hook timing: Is 9c5b034 a good solution? |
Thanks for both. Hookable issue is solved via unjs/hookable@23d9ff4 btw we can revert it back and try :) |
This reverts commit 9c5b034.
/cc @danielroe maybe wrong in hookable types?
autoImports
to imports
autoImports
to imports
Merged
7 tasks
This was referenced Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
As this feature now goes beyond just auto-imports, the naming
autoImports
becomes a bit confusing and ambiguous. See #6768 for more.This PR renames Nuxt option
autoImports
toimports
and hooksautoImports:*
toimports:*
. This also aligns withcomponents
option.π Migration
autoImports
named toimports
. HooksautoImports:*
renamed toimports:*
.for
nuxt.config.ts
:for module authors: