Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs(api): add <NuxtWelcome /> component docs #6745

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Conversation

umutiq
Copy link
Contributor

@umutiq umutiq commented Aug 18, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#14613

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Solves nuxt/nuxt#14613

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 18, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit f7f4a11
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fe44bb2ae04e00087ae695
😎 Deploy Preview https://deploy-preview-6745--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title docs: added <NuxtWelcome /> documentation docs(api): add <NuxtWelcome /> component docs Aug 18, 2022
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0
Copy link
Member

pi0 commented Aug 18, 2022

Do you mind to add a ::ReadMore link to https://github.com/nuxt/ui?

@umutiq
Copy link
Contributor Author

umutiq commented Aug 18, 2022

@pi0 Since we didn't mention it's imported from @nuxt/ui, i think it's inapporpriate.

@danielroe
Copy link
Member

danielroe commented Aug 18, 2022

Maybe we should mention it then. I think it would be a good idea for people to know where (for example) to make PRs if they have improvements.

@danielroe danielroe added the documentation Improvements or additions to documentation label Aug 18, 2022
@umutiq
Copy link
Contributor Author

umutiq commented Aug 18, 2022

@danielroe I added alert and Readmore links to document. Can you check it?

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0 pi0 merged commit ee25a15 into nuxt:main Aug 18, 2022
@BD103
Copy link

BD103 commented Aug 19, 2022

Thank you!

@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document <NuxtWelcome />
5 participants