Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't set asyncData to existing payload on CSR if initialCache is disabled #6640

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13872

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were ignoring initialCache setting if data was already present in payload. I've exempted us from respecting initialCache if we are hydrating. (In this case, server: false should be used rather than initialCache: false.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 15, 2022
@danielroe danielroe requested a review from pi0 August 15, 2022 13:43
@danielroe danielroe self-assigned this Aug 15, 2022
@netlify
Copy link

netlify bot commented Aug 15, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 7075c9f
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fa4dc1ec461900093d9da2

@pi0 pi0 merged commit 33e7fc1 into main Aug 15, 2022
@pi0 pi0 deleted the fix/client-cache branch August 15, 2022 13:55
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useLazyAsyncData ignores initialCache:false option
2 participants