Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: change info to danger for pages root element #6528

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

genu
Copy link
Contributor

@genu genu commented Aug 11, 2022

πŸ”— Linked issue

nuxt/nuxt#13350

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When < NuxtPage/> is a root element, it throws a Failed to execute 'insertBefore' on 'Node' error

There is a note in the docs that it is recommended to not to make it a root element, but I think this should be marked as a danger because it actually causes an error if you do.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 11, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 0f42340
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f548886e0f09000a745bd1

@genu genu marked this pull request as ready for review August 11, 2022 18:20
@pi0 pi0 changed the title docs: change info to danger docs: change info to danger for pages root element Aug 11, 2022
@pi0 pi0 merged commit 1072140 into nuxt:main Aug 11, 2022
@pi0
Copy link
Member

pi0 commented Aug 11, 2022

Thanks

@pi0 pi0 mentioned this pull request Aug 11, 2022
@genu genu deleted the docs/danger branch August 11, 2022 23:08
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants