Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): ensure asyncdata handler has nuxt app context #6472

Merged
merged 3 commits into from
Aug 9, 2022
Merged

fix(nuxt): ensure asyncdata handler has nuxt app context #6472

merged 3 commits into from
Aug 9, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression of #6441 - we were not passing context to asyncdata calls.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 9, 2022
@danielroe danielroe requested a review from pi0 August 9, 2022 21:38
@danielroe danielroe self-assigned this Aug 9, 2022
@netlify
Copy link

netlify bot commented Aug 9, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 19cc72c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f2d57acee4fe0008a44b7b

@pi0 pi0 changed the title fix(nuxt): provide nuxt app to asyncdata handler fix(nuxt): immediately call asyncData handler Aug 9, 2022
@danielroe danielroe changed the title fix(nuxt): immediately call asyncData handler fix(nuxt): ensure asyncdata handler has nuxt app context Aug 9, 2022
@pi0 pi0 merged commit 5232c1b into main Aug 9, 2022
@pi0 pi0 deleted the fix/data-context branch August 9, 2022 21:48
@pi0 pi0 mentioned this pull request Aug 11, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0