This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor(nuxt): enable strict type checking #6368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Aug 4, 2022
pi0
reviewed
Aug 4, 2022
pi0
reviewed
Aug 4, 2022
antfu
commented
Aug 10, 2022
pi0
approved these changes
Aug 12, 2022
This is a nice initiative π Merging to avoid stalling PR. There has been some leftovers also in packages/nuxt which we can improve type coverage and fix errors. I've triple checked but there might be regressions with changes. /cc @danielroe heads up @antfu Can we please allow unplugin define to make input options mandatory? It can help to properly type them. ππΌ |
@pi0 Published |
7 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
The first step migrating the entire repo to
strict: true
tsconfig.json
to mark the scope of strict - later after we migrate all modules to strict, we could then remove all the sub tsconfig and turn the root levelstrict: true
wrapInRef
is redundant - ref already does that: https://github.com/vuejs/core/blob/4d7803ed28fb67d45a83d3500f5407754e65bf64/packages/reactivity/src/ref.ts#L90-L95AsyncData
does not indicate the data could possibly benull
, this PR also catches that.π Checklist