Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): resolve plugins and middleware to their full path #6350

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14479

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When a plugin is in injected like /path/to/someplugin without the extension, we can likely match /path/to/someplugin.*. A more accurate, but more costly, route would be to use resolvePath when adding plugins (or to normalize afterwards before app:resolve.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 4, 2022
@danielroe danielroe requested a review from pi0 August 4, 2022 09:56
@danielroe danielroe self-assigned this Aug 4, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 64a9656
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ebd3941d113e000c1593d8

@pi0
Copy link
Member

pi0 commented Aug 4, 2022

Is this possible to add a simple usage test fixture?

packages/nuxt/src/core/app.ts Outdated Show resolved Hide resolved
packages/nuxt/src/core/app.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 August 4, 2022 14:11
@pi0 pi0 changed the title fix(nuxt): include plugins/middleware without extensions in transform fix(nuxt): resolve plugins and middleware to their full path Aug 4, 2022
@pi0 pi0 merged commit 746d553 into main Aug 4, 2022
@pi0 pi0 deleted the fix/unctx-plugins branch August 4, 2022 15:15
@max5432112345
Copy link

Deploy failed for nuxt3-docs
Today at 5:11 PM

PR#6350: fix/unctx-plugins@64a9656

@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n/useRouter/useNuxtApp - Error nuxt instance unavailable
3 participants