This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): generate 200.html and 404.html spa fallback files
#6308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
changed the title
200.html and 404.html fallback files200.html and 404.html spa fallback files
|
This still works only for |
|
@manniL Yes 👍 We need nitro route rules as discussed to to selectively set spa mode on these routes when generating with ssr enabled. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
As a regression of unjs/nitro#166, we were generating
dist/200/index.htmlinstead ofdist/200.htmlfor spa fallbacks. This makes expected output.📝 Checklist