Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): separate routes for different suspense forks #6275

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 1, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#14456

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR provides the current route directly at the point of suspense, meaning within the context of a suspense fork, the route will not change until suspense has resolved. We also update the default useRoute behaviour to mean that the route will not change outside of a page context until suspense has resolved.

Context: #4124, nuxt/nuxt#13630, #4092.


Previous behaviour:

CleanShot 2022-08-01 at 09 50 46

New behaviour:

CleanShot 2022-08-01 at 09 51 37

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working pages labels Aug 1, 2022
@danielroe danielroe self-assigned this Aug 1, 2022
@netlify
Copy link

netlify bot commented Aug 1, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 5b2fecf
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62e79f2fd02cac0008ab631f

@danielroe danielroe requested a review from pi0 August 1, 2022 09:06
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ❀️

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All seems great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

route updates before suspense resolves
4 participants