-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxt): add fetchpriority
attribute and literal typings for meta components
#6251
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
<Script>
and <Link>
Shall we narrow down the accepted values for the |
💪🏽 |
Sorry, I have copied the code from #6262 for adding typings for |
<Script>
and <Link>
<Script>
and <Link>
and minor improvements in types :)
<Script>
and <Link>
and minor improvements in types :)<Script>
and <Link>
and minor improvements in types :)
Great enhancement! I have closed #6262 in favor of your changes. There are two remarks that I've got:
|
<img crossorigin /> is easier than <img crossorigin="" /> And even browser parse the html with crossorigin attr empty string as |
I am sorry if I am wrong :( |
All I am thinking is whether the following would be preferable:
Let's wait for others to express their thoughts, not sure which way to go :) |
Ok 🙌 |
type LinkRelationship =
| "alternate"
| "author"
| "canonical"
| "dns-prefetch"
| "help"
| "icon"
| "license"
| "manifest"
| "me"
| "modulepreload"
| "next"
| "pingback"
| "preconnect"
| "prefetch"
| "preload"
| "prerender"
| "prev"
| "search"
| "stylesheet"
| String; Added types for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the direction of this PR. ❤️ Would you revert the various style/lint changes that have been made by your IDE?
Yeah sure 🙌 |
Made suggested change (not sure) 😄 |
<Script>
and <Link>
and minor improvements in types :)fetchpriority
attribute to the <Script>
and <Link>
components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice enhancement - thanks! ❤️
fetchpriority
attribute to the <Script>
and <Link>
componentsfetchpriority
attribute and literal typings for meta components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
My pleasure 💪🙌 |
Added fetchpriority attr in script and link component.