-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(schema): exclude functions from DeepPartial
#6176
Conversation
β Deploy Preview for nuxt3-docs canceled.
|
@@ -13,7 +13,7 @@ export default { | |||
* Properties that will be set directly on `Vue.config` for vue@2. | |||
* | |||
* @see [vue@2 Documentation](https://v2.vuejs.org/v2/api/#Global-Config) | |||
* @type {import('vue/types/vue').VueConfiguration} | |||
* @type {typeof import('vue/types/vue').VueConfiguration} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it makes sense to automatically infer this in untyped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that we have a two stage build here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I mean if untyped can add automatically add typeof
prefix to import
in @type
annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(anyway, this fix makes sense. Was thinking of a way to avoid future issues like this)
DeepPartial
π Linked issue
resolves nuxt/nuxt#14162
β Type of change
π Description
An early return for functions solves some issues with functional types (including missing types for
hook
, for example). There were also a couple of incorrect types in_app
.π Checklist