This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxt)!: add support for components/global
#6070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
danielroe
commented
Jul 25, 2022
7 tasks
1e62bcf
to
9a0c2b0
Compare
pi0
approved these changes
Jul 27, 2022
components/global
Merged
7 tasks
components/global
components/global
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
enhancement
New feature or request
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#14051
β Type of change
π Description
components/global
, please move them to new directory otherwise they will loseGlobal
suffix and will be globally available as lazy chunks.This PR:
#components
on client-side will no longer pull in server-only components or vice versa.~/components/global
orMyComponent.global.ts
. It does not change how they are made available; it's still via async registration.I'm happy to split out 1 & 2 if that would be helpful in reviewing it. Let me know if so.
π Checklist