Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): avoid creating server for production build #5941

Merged
merged 2 commits into from
Jul 17, 2022
Merged

fix(vite): avoid creating server for production build #5941

merged 2 commits into from
Jul 17, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 16, 2022

🔗 Linked issue

fix nuxt/nuxt#14246
#5875 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

@netlify
Copy link

netlify bot commented Jul 16, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 10b8cd6
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d419621b15420008a0c6af

@pi0 pi0 changed the title fix(vite): avoid starting server in build fix(vite): avoid creating server for production build Jul 17, 2022
pi0
pi0 approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix. Thanks!

@pi0 pi0 merged commit 4abcfb6 into main Jul 17, 2022
@pi0 pi0 deleted the fix/vite-dev-server-in-build branch July 17, 2022 14:17
@pi0 pi0 mentioned this pull request Jul 17, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error: ERROR [unhandledRejection] Cannot read properties of null (reading 'config')
3 participants
@antfu @pi0 @danielroe