Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): lazy load and tree-shake error templates #5930

Merged
merged 7 commits into from
Jul 15, 2022
Merged

fix(nuxt): lazy load and tree-shake error templates #5930

merged 7 commits into from
Jul 15, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently error-dev is being bundled and not tree-shaken. This change uses a dynamic import for dev errors which allows vite to tree-shake it out of the final build.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage label Jul 15, 2022
@danielroe danielroe requested a review from pi0 July 15, 2022 21:05
@danielroe danielroe self-assigned this Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 1a1a368
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d1e5f6395be8000838439d

@pi0 @kevinmarrec
Update packages/nuxt/src/app/components/nuxt-error-page.vue
1a1a368 
Co-authored-by: Kevin Marrec <kevin@marrec.io>
@pi0 pi0 requested a review from kevinmarrec July 15, 2022 22:11
@pi0 pi0 changed the title fix(nuxt): tree-shake dev error page from bundle fix(nuxt): lazy load and tree-shake error templates Jul 15, 2022
@pi0 pi0 merged commit dce07e5 into main Jul 15, 2022
@pi0 pi0 deleted the perf/exclude-dev-error branch July 15, 2022 22:15
@pi0 pi0 mentioned this pull request Jul 15, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@kevinmarrec kevinmarrec kevinmarrec approved these changes

Assignees

@danielroe danielroe

Labels
3.x 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielroe @pi0 @kevinmarrec