This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: expand contribution guide for ecosystem #5922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
613b4f8
to
db123b6
Compare
Looking at Contribution section it is really nice and good to me to add and iterate over honestly even with current state π Some small things could be improved:
|
Co-authored-by: Anthony Fu <hi@antfu.me>
db123b6
to
e5e8bd5
Compare
pi0
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This is an initial stab at a more generic contribution guide for the Nuxt ecosystem, splitting out generic contribution guidance from the more specific guidance for the nuxt/framework repository specifically.
The following flowcharts are taken from https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#issue-triaging-workflow. When we upgrade to Nuxt 3, we can create a dedicated component to render these, but I think we can simply link to rendered chart until that point. (cc: @antfu)
π Checklist