This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(nuxt): allow getRouteFromPath to use objects
#5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Jul 14, 2022
pi0
changed the title
getRouteFromPath to use objectsgetRouteFromPath to use objects
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#14170
❓ Type of change
📚 Description
Allows the
getRouteFromPathfunction to accept objects. I convert the object to a URL first by using thestringifyParsedURLinufoand the code proceeds as normal. The playground has an example of a single-page app using an object to set the path, query, and hash. The issue is described in nuxt/nuxt#14170.This is my first time playing around with something like this, so I know there will probably be many things that need to be changed or this being closed entirely.
Resolves nuxt/nuxt#14170
📝 Checklist