Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: use defineLazyHandler in wasm example #5797

Merged
merged 5 commits into from
Jul 11, 2022

Conversation

valcosmos
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 9, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 5f5d0b4
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62c99c454ec8690009120036

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would you also update the return so it's not using req but event?

examples/experimental/wasm/server/api/sum.ts Outdated Show resolved Hide resolved
examples/experimental/wasm/server/api/sum.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix lazyload in wasm exmaple docs: use defineLazyHandler in wasm example Jul 9, 2022
@valcosmos
Copy link
Contributor Author

Thanks!

Would you also update the return so it's not using req but event?

Thanks for your reply, and I have replaced req with event.

@valcosmos valcosmos requested a review from danielroe July 9, 2022 16:21
@pi0 pi0 merged commit ac4e09b into nuxt:main Jul 11, 2022
@pi0
Copy link
Member

pi0 commented Jul 11, 2022

Thanks!

@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants