Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(webpack): transpile vue-demi #5721

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(webpack): transpile vue-demi #5721

merged 1 commit into from
Jul 6, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#14190

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We need to transpile vue-demi as webpack otherwise tries to resolve this externally.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working webpack labels Jul 4, 2022
@danielroe danielroe requested a review from pi0 July 4, 2022 22:23
@danielroe danielroe self-assigned this Jul 4, 2022
@netlify
Copy link

netlify bot commented Jul 4, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 885b373
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62c3685a04de1a0008d5ead8

@pi0 pi0 merged commit 8ffe2a3 into main Jul 6, 2022
@pi0 pi0 deleted the fix/vue-demi-transpile branch July 6, 2022 18:23
@pi0 pi0 mentioned this pull request Jul 11, 2022
Merged
@liuzycc
Copy link

liuzycc commented Aug 4, 2022 •
edited
Loading

version:v3.0.0-rc.6
You'll still get an error
H3Error: Cannot find package 'vue-demi'
need npm i vue-demi

@danielroe
Copy link
Member Author

@liuzycc Please open a new issue with a reproduction 🙏

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find package 'vue-demi' when starting nuxt project from scratch with webpack
3 participants
@danielroe @liuzycc @pi0