Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt): prerender all pages by default #5709

Merged
merged 3 commits into from
Jul 7, 2022
Merged

feat(nuxt): prerender all pages by default #5709

merged 3 commits into from
Jul 7, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#13945

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds all non-dynamic routes to the prerenderer by default, as we can't always rely on the crawler to fetch every page.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request pages 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jul 4, 2022
@danielroe danielroe requested a review from pi0 July 4, 2022 10:07
@danielroe danielroe self-assigned this Jul 4, 2022
@netlify
Copy link

netlify bot commented Jul 4, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 05733d8
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62c6ba755ac0c90009282f56

@danielroe danielroe marked this pull request as draft July 4, 2022 10:16
@danielroe danielroe marked this pull request as ready for review July 4, 2022 10:39
@danielroe danielroe requested a review from pi0 July 7, 2022 11:13
@pi0 pi0 merged commit 271262e into main Jul 7, 2022
@pi0 pi0 deleted the feat/pages-prerender branch July 7, 2022 15:07
@pi0 pi0 mentioned this pull request Jul 11, 2022
Merged
@Tahul Tahul mentioned this pull request Jan 19, 2023
Closed
@pi0 pi0 mentioned this pull request Jul 11, 2022
Merged
7 tasks
@johannschopplich johannschopplich mentioned this pull request Jan 19, 2023
Closed
danielroe added a commit to nuxt-modules/ionic that referenced this pull request Aug 17, 2022
@danielroe
fix: remove prerendering workaround
3b18f8f 
now present in nuxt itself: nuxt/framework#5709
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yarn generate not generating pages for components on the pages directory
2 participants
@danielroe @pi0