Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxi): improve env update message #5430

Merged
merged 3 commits into from
Jun 12, 2022
Merged

refactor(nuxi): improve env update message #5430

merged 3 commits into from
Jun 12, 2022

Conversation

ennioVisco
Copy link
Contributor

Updated the warning message to provide some insights to the developers about the fact that he did not do something wrong per se, but many libraries would not be behaving correctly.

🔗 Linked issue

Related to a9c061c#commitcomment-75926157 and nuxt/nuxt#14057.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Updated the warning message to provide some insights to the developers about the fact that he did not do something wrong per se, but many libraries would not be behaving correctly.
@netlify
Copy link

netlify bot commented Jun 12, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 90edc91
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62a6646719201b000950ed0c

packages/nuxi/src/utils/env.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title Update env.ts refactor(nuxi): improve env update message Jun 12, 2022
@pi0 pi0 requested a review from danielroe June 12, 2022 22:02
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 9d28c0a into nuxt:main Jun 12, 2022
@pi0 pi0 mentioned this pull request Jun 12, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants