Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(types): tidy types for useAsyncData #5340

Merged
merged 2 commits into from
Jun 8, 2022
Merged

fix(types): tidy types for useAsyncData #5340

merged 2 commits into from
Jun 8, 2022
+8 −1

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 7, 2022

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Use Pick<T, K> only when necessary to make the type cleaner

Before

image

Or

image

After

image

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 7, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit f4ce2ae
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62a06f1d1ee80b00086d8354

@antfu antfu requested a review from danielroe June 7, 2022 23:03
danielroe
danielroe approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👌

pi0
pi0 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pi0 pi0 merged commit eafd92c into main Jun 8, 2022
@pi0 pi0 deleted the fix/type-pick-from branch June 8, 2022 19:45
@pi0 pi0 mentioned this pull request Jun 10, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfu @pi0 @danielroe