Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): add ssrContext types on NuxtApp #5333

Merged
merged 3 commits into from
Jun 8, 2022
Merged

fix(nuxt): add ssrContext types on NuxtApp #5333

merged 3 commits into from
Jun 8, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14102

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds types to ssrContext (with req/res deprecated).

Relevant code changes: it also removes redirected (Nuxt 2, not otherwise used in Nuxt 3 codebase) and doesn't pass an empty object to initialise server entry.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types labels Jun 7, 2022
@danielroe danielroe requested a review from pi0 June 7, 2022 13:47
@danielroe danielroe self-assigned this Jun 7, 2022
@netlify
Copy link

netlify bot commented Jun 7, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 0b5efc6
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/629f74c52bab490008be0e1b

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0 pi0 merged commit 822928b into main Jun 8, 2022
@pi0 pi0 deleted the fix/ssrcontext-types branch June 8, 2022 19:37
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No types for nuxtApp.ssrContext
3 participants