This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): ensure url is not empty string #4781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#13906
Reproduction: https://stackblitz.com/edit/nuxt-starter-mc3z36
β Type of change
π Description
We detect redirection happens when after router middleware, initialURL is mismatching current route's fullPath. While initialURL from req.url is
/
,fullPath
is an empty string due to a vue-router bug. Additionally, I've added''
to'/'
fallback fornavigateTo
to ensure this issue won't happen in other places when callingrouter.resolve
Other than workaround for upstream issue, this PR tries to improve path compare to avoid unnecessary navigations.
π Checklist